-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reader: remove counting of blocks #2166
Conversation
db58ced
to
06f75ac
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2166 +/- ##
==========================================
+ Coverage 89.92% 90.04% +0.11%
==========================================
Files 989 989
Lines 35637 35452 -185
==========================================
- Hits 32048 31921 -127
+ Misses 3589 3531 -58
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add isEOF()
to serial csv reader too? I wonder if that can simplify the control logic by eventually remove doneAfterEmptyBlock
later.
By removing |
b298c18
to
b0e9df4
Compare
b45df3c
to
6ae22b8
Compare
This allows us to move toward removing all upfront counting. None of the readers actually depend on upfront counting of the number of blocks.
6ae22b8
to
67cbaca
Compare
This allows us to move toward removing all upfront counting. None of the readers actually depend on upfront counting of the number of blocks.
Depends on #2156 , to avoid a merge conflict.